Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

too many open files #76

Open
tcurdt opened this issue Jul 4, 2016 · 8 comments
Open

too many open files #76

tcurdt opened this issue Jul 4, 2016 · 8 comments

Comments

@tcurdt
Copy link

tcurdt commented Jul 4, 2016

I was trying to build your site but when serving the pages I get

$ make w
gostatic -w config
Rendering 0 changed pages of 292 total
Starting server at *:8000...
2016/07/04 22:37:34 http: Accept error: accept tcp [::]:8000: accept: too many open files; retrying in 5ms
2016/07/04 22:37:34 http: Accept error: accept tcp [::]:8000: accept: too many open files; retrying in 10ms

Building it and running python -m SimpleHTTPServer 8000 instead works fine though.
@piranha
Copy link
Owner

piranha commented Jul 5, 2016

Running ulimit -S -n 4096 will fix that. gostatic opens all files and it takes time to GC them it seems, so it can blow with such an error.

@piranha piranha closed this as completed Jul 5, 2016
@tcurdt
Copy link
Author

tcurdt commented Jul 5, 2016

OK, let's rephrase that then: why does it open all files and keep them open?

@piranha
Copy link
Owner

piranha commented Jul 5, 2016

I think first part is obvious, but second one is not. :) I did look at why it opens them IIRC, but I didn't action on it. Not sure why it keeps them open though, that needs to be researched again it seems. :)

@tcurdt
Copy link
Author

tcurdt commented Jul 5, 2016

I think first part is obvious, but second one is not. :)

true :)

that needs to be researched again it seems.

care to re-open then?

@piranha piranha reopened this Jul 5, 2016
@piranha
Copy link
Owner

piranha commented Jul 5, 2016

Sure! :)) If you want to research/fix that, I would really appreciate it! If not, I guess I'll look at that sometime, but not sure when - a bit too busy lately with work and real-life stuff.

@nochso
Copy link

nochso commented Jul 26, 2016

Had a look at the FAQ for fsnotify (which is imported by lib/watch.go)

How many files can be watched at once?

There are OS-specific limits as to how many watches can be created:

Linux: /proc/sys/fs/inotify/max_user_watches contains the limit, reaching this limit results in a "no space left on device" error.
BSD / OSX: sysctl variables "kern.maxfiles" and "kern.maxfilesperproc", reaching these limits results in a "too many open files" error.

As long as you're watching them, the files have to be open. It's easiest to increase the limit.

Alternatively you could use a "polling" approach which is way slower, but will work for any amount of files.

@tcurdt
Copy link
Author

tcurdt commented Jul 26, 2016

Well, that statement isn't true for all OS. On macOS it would be great to use FSEvents.

https://github.com/emcrisostomo/fswatch

But it sounds like there is a progress in supporting that with fsnotify.

golang/go#4068

@tcurdt
Copy link
Author

tcurdt commented Jul 26, 2016

...and specifically fsnotify/fsnotify#11

@s-kostyaev s-kostyaev mentioned this issue Jan 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@piranha @tcurdt @nochso