Add kind APPLICATION #5358
Closed
Add kind APPLICATION #5358
+179
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
ffjlabo
requested review from
nghialv,
khanhtc1202,
kentakozuka,
t-kikuc and
Warashi
as code owners
ffjlabo
commented
Nov 21, 2024
| @@ -78,6 +78,17 @@ func (a *Application) ContainLabels(labels map[string]string) bool { | |||
| return true | |||
| } | |||
|
|
|||
| func (a *Application) GetKindString() string { | |||
There was a problem hiding this comment.
I wanted to use GetKind. But there is the same name method generated by protobuf.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5358 +/- ##
==========================================
+ Coverage 25.41% 25.43% +0.02%
==========================================
Files 446 446
Lines 47807 47821 +14
==========================================
+ Hits 12150 12164 +14
Misses 34708 34708
Partials 949 949 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
ffjlabo
force-pushed
the
add-application-definition
branch
from
f0fd4d8 to
cffd56a
Compare
|
After a discussion with @khanhtc1202, I found that this is no use for pipedv1. We don't use the So, close this PR. FYI, draft migration process.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Added new kind
APPLICATIONas ApplicationKind and the method to get the kind as string. This is for the app in pipedv1.In the pipedv1, we use labels["kind"] instead of the current Kind.
See more: https://github.com/pipe-cd/pipecd/blob/master/docs/rfcs/0015-pipecd-plugin-arch-meta.md#for-kind
Why we need it:
Which issue(s) this PR fixes:
Part of #5252
Does this PR introduce a user-facing change?: