PHP 8.4 | Fix implicitly nullable parameters (7.x) #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameter with a `null` default value, which are not explicitly declared as nullable. This commit fixes all found instances of that in the PHPSpec codebase. Includes updating the documentation to match (where relevant, i.e. only existing documentation has been touched). Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
jrfnl
changed the title
|
Note: this PR targets the 7.5 branch. Sister-PR #1473 does the same for the main/8.0 branch. |
This was referenced Aug 21, 2024
stof
approved these changes
Aug 21, 2024
|
It needs to get rid of |
This was referenced Oct 29, 2024
|
Filed #1479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 deprecates implicitly nullable parameters, i.e. typed parameter with a
nulldefault value, which are not explicitly declared as nullable.This commit fixes all found instances of that in the PHPSpec codebase.
Includes updating the documentation to match (where relevant, i.e. only existing documentation has been touched).
Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types