Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper support AMQP for array and timestamp types for dead lettering #272

Merged
merged 16 commits into from
Mar 6, 2017
Merged

Proper support AMQP for array and timestamp types for dead lettering #272

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f120cc7
Convert numeric PHP array to AMQP array instead of table (refs #271)
lstrojny Mar 2, 2017
edc13a9
Implement timestamp value object
lstrojny Mar 3, 2017
7faab3b
Remove SVN legacy
lstrojny Mar 3, 2017
3f4a8d0
Mark AMQPTimestamp class as final
lstrojny Mar 3, 2017
ff3607b
Add test to verify dead lettering behavior
lstrojny Mar 4, 2017
ac14b95
More stable test
lstrojny Mar 4, 2017
a81c43b
PHP 5 support for AMQPTimestamp
lstrojny Mar 4, 2017
8ab4153
PHP 5 support
lstrojny Mar 4, 2017
c30c3ef
More debugging output
lstrojny Mar 4, 2017
4abe970
Normalize headers for different rabbitmq versions
lstrojny Mar 4, 2017
557ab05
Cleanup .travis.yml
lstrojny Mar 4, 2017
0dafdfa
Add bound checks for AMQPTimestamp
lstrojny Mar 5, 2017
2bb1a68
Add TSRMLS_CC
lstrojny Mar 5, 2017
016e7ee
Fix PHP5 build
lstrojny Mar 5, 2017
9a2a2a9
Remove duplicate tests
lstrojny Mar 5, 2017
be0c823
Style
lstrojny Mar 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add TSRMLS_CC
  • Loading branch information
@lstrojny
lstrojny committed Mar 5, 2017
commit 2bb1a68fac68390f5516d8c5719d6d20657d92a7
2 changes: 1 addition & 1 deletion amqp_type.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ zend_bool php_amqp_type_internal_convert_php_to_amqp_field_value(zval *value, am
field->kind = AMQP_FIELD_KIND_VOID;
break;
case IS_OBJECT:
if (instanceof_function(Z_OBJCE_P(value), amqp_timestamp_class_entry)) {
if (instanceof_function(Z_OBJCE_P(value), amqp_timestamp_class_entry TSRMLS_CC)) {
#if PHP_MAJOR_VERSION >= 7
zval result;
zend_call_method_with_0_params(value, amqp_timestamp_class_entry, NULL, "gettimestamp", &result);
Expand Down