Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix #3953 #4410

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Try to fix #3953 #4410

wants to merge 1 commit into from
+2 −0

Conversation

GarryLai
Copy link

@GarryLai GarryLai commented Jul 17, 2024 •
edited
Loading

Acceptance Criteria:

  • Features and enhancements must be fully implemented so that they can be released at any time without additional work
  • Automated unit and/or acceptance tests are mandatory to ensure the changes work as expected and to reduce repetitive manual work
  • Frontend components must be responsive to work and look properly on phones, tablets, and desktop computers; you must have tested them on all major browsers and different devices
  • Documentation and translation updates should be provided if needed
  • In case you submit database-related changes, they must be tested and compatible with SQLite 3 and MariaDB 10.5.12+

@lastzero
Copy link
Member

Thank you! Did this change work for you when you tested it locally?

@GarryLai
Copy link
Author

Thank you! Did this change work for you when you tested it locally?

Yes, I tested whether I turn on "Quality Filter" or not, it worked.

lastzero added a commit that referenced this pull request Jul 28, 2024
@lastzero
Places: Apply quality filter when performing search requests #3953 #4410
18b81d0 


Signed-off-by: Michael Mayer <michael@photoprism.app>
@lastzero
Copy link
Member

Thank you! The pull request was really helpful. After seeing it, I dug a little deeper and found that the regular Search UI sets the quality filter when enabled, while the Places UI did not. With today's changes, this should be fixed (except maybe for edge cases where you use the maps in combination with other views or when you reuse it after changing the scope/other filters).

We started a new development preview build for you so you can test this:

Please let us know if it works for you! 🤞

@lastzero lastzero added please-test Ready for acceptance test feedback wanted We'd love to hear your thoughts on this! labels Jul 28, 2024
@CLAassistant
Copy link

CLAassistant commented Oct 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feedback wanted We'd love to hear your thoughts on this! please-test Ready for acceptance test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GarryLai @lastzero @CLAassistant