Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip: Live Photo downloads should include all related media files #437

Open
Chadea opened this issue Aug 1, 2020 · 18 comments
Open

Zip: Live Photo downloads should include all related media files #437

Chadea opened this issue Aug 1, 2020 · 18 comments
Assignees
Labels
idea Feedback wanted / feature request live Hybrid photo/video file format support please-test Ready for acceptance test

Comments

@Chadea
Copy link

Chadea commented Aug 1, 2020

Title.

When downloading live photos (mine have jpg, heic, and the mov) it would be good if all 3 files were zipped for download. Currently it appears to just download the singular jpg/still image associated with that photo.

@calucido
Copy link

calucido commented Aug 6, 2020

Also, Firefox sometimes has issues asking permission to download multiple files at the same time.
If it's ok with the devs, I'd like to take this on as a first issue.

@lastzero
Copy link
Member

lastzero commented Aug 6, 2020

Sure, pull requests welcome :) still on vacation until next week

@calucido
Copy link

calucido commented Aug 6, 2020

@Chadea how are you uploading the live photos? Whenever I transfer them off my phone (to Photoprism or to my Mac), I find that they're converted to JPGs.

@Chadea
Copy link
Author

Chadea commented Aug 7, 2020

I’ve been copying them to the import folder over SMB using an app (PhotoSync) on my phone, I had to add the yaml and json sidecar option to my photoprism instance. That allows the small .movs to be linked. As detailed when I asked #422

@Chadea
Copy link
Author

Chadea commented Aug 7, 2020

I should add, when I sync I have turned on jpg so I have a .jpg .heic .mov and photoprism now links them.

@lastzero lastzero added the idea Feedback wanted / feature request label Sep 20, 2020
@graciousgrey graciousgrey changed the title Feature Request - When downloading live photos, zip all the associated files Download / When downloading live photos, zip all the associated files Nov 26, 2020
@graciousgrey graciousgrey changed the title Download / When downloading live photos, zip all the associated files Download: When downloading live photos, zip all the associated files Jan 5, 2021
@miguelarios
Copy link

I created this issue #934 that relates to this issue because I almost think it be nicer to let the user decide which version to pick from.

lastzero added a commit that referenced this issue Jan 27, 2021
Related issues:
- Configure download name for files and albums #848
- When downloading live photos, zip all the associated files #437
@lastzero lastzero removed the unfunded label Nov 1, 2021
@lastzero
Copy link
Member

Would this be resolved when you change the settings as described at https://docs.photoprism.app/getting-started/config-files/settings/#file-downloads?

@lastzero lastzero added the please-test Ready for acceptance test label Apr 17, 2023
@melyux
Copy link

melyux commented Jun 5, 2023

I tried with those setting changes but no luck. Only getting a .heif when downloading Live Photos

Download:
Name: file
Disabled: false
Originals: true
MediaRaw: true
MediaSidecar: false

@graciousgrey
Copy link
Member

@melyux What files do you see on the files tab of your Live Photo? Are the related JPG and MOV files located in Originals or in Sidecar?

@melyux
Copy link

melyux commented Jun 8, 2023

The files tab shows:

  • .heic file in Originals
  • .mov file in Originals
  • .heic.jpg file in Sidecar

@graciousgrey
Copy link
Member

What version are you running? I just tested the same scenario on my own setup:

Disabled: false
Originals: true
MediaRaw: true
MediaSidecar: false

Results in downloading the .heic and .mov file as those are the originals.

Disabled: false
Originals: false
MediaRaw: true
MediaSidecar: false

Results in downloading the .heic and .mov and .jpg file.

Note that those settings are not applied if you download a complete album, see also: https://docs.photoprism.app/user-guide/settings/general/#downloads

@lastzero lastzero moved this to Ideas 💭 in Roadmap 🚀✨ Jun 8, 2023
@melyux
Copy link

melyux commented Jun 13, 2023

I'm on the latest, seeing some interesting behavior:

  • Desktop Safari: The .heif and the .mov files both download sequentially as individual files (nice)
  • iOS Mobile Safari: Only the .mov file downloads
  • iOS Web App (Homescreen App): Only the .heif file downloads

@lastzero
Copy link
Member

You need to give permission to download multiple files.

@melyux
Copy link

melyux commented Jun 13, 2023

I don't think iOS has an option for that. Maybe "setting a delay between file downloads allowed enough time for Safari to process that there should be multiple files downloaded."

@lastzero
Copy link
Member

Could be it. If true, Apple should fix this ASAP.

@melyux
Copy link

melyux commented Jun 13, 2023

Current behavior is honestly not too bad, but sometime only the .mov file comes (randomly), so that's not good. I think most people would be mostly happy with just the image downloading, but no one wants to download only the .mov of a Live Photo

@lastzero
Copy link
Member

We can zip it like back in the 90s? Vision Pro.

@melyux
Copy link

melyux commented Jun 13, 2023

Maybe prioritize the .heif (or the image) file to always come first when doing multiple downloads from a Live Photo?

@lastzero lastzero added the live Hybrid photo/video file format support label Sep 21, 2023
@lastzero lastzero changed the title Download: When downloading live photos, zip all the associated files Zip: Include image and video when downloading Live Photos Sep 21, 2023
@lastzero lastzero changed the title Zip: Include image and video when downloading Live Photos Zip: Add image and video when downloading Live Photos Sep 21, 2023
@lastzero lastzero changed the title Zip: Add image and video when downloading Live Photos Zip: Live Photo downloads should include all related media files Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Feedback wanted / feature request live Hybrid photo/video file format support please-test Ready for acceptance test
Projects
Status: Ideas 💭
Development

No branches or pull requests

6 participants