Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: The "Back" and "Forward" buttons of the mouse are misused for "Drag/Zoom" when viewing an image in Google Chrome #3542

Open
fireattack opened this issue Jul 11, 2023 · 5 comments
Labels
frontend Requires experience with HTML/JS/CSS help wanted Well suited for external contributors! ux Impacts User Experience

Comments

@fireattack
Copy link

fireattack commented Jul 11, 2023

1. What is not working as documented?

When viewing a specific photo, all the buttons on mouse are treated as "drag/zoom". This includes left button, right button, middle button, back button and forward button.

This is pretty uncommon and IMO does not make sense. It should be one button (usually left button) only, or at most left and right buttons. And it definitely shouldn't override back and forward buttons.

2. How can we reproduce it?

Steps to reproduce the behavior:

  1. Go to https://demo.photoprism.app/library/browse
  2. Find a large enough image (so that the "click to zoom in" function will kick in), and click to view it.
  3. Click back button on the mouse on the image.
  4. The images zooms in, just like when you click left button, instead of "go back" like how would it happen when you click back button on toolbar or alt+←.

(Optional) you can also drag (pan) image around by holding back/forward button.

3. What behavior do you expect?

Go back.

The issue seems to be Chrome/Chromium-based browser only: can reproduce on Chrome and Edge.

I cannot reproduce it on Firefox.

@fireattack fireattack added the bug Something isn't working label Jul 11, 2023
@lastzero
Copy link
Member

@fireattack This sounds more like a UX issue than a bug to me (and it's the first time this has been reported), but we're happy to improve it if we can, at least in the new viewer that we're going to build.

At the moment we are using PhotoSwipe 4 as a viewer, which is a standard JS component and not maintained by us:

  • Could you verify if you have the same issues with their demo?
  • If so, can you please search the code repository and developer forum for any related issues?

That would help us get a better understanding. Also, you should check if you have a special mouse driver installed, or use custom settings for your mouse or browser.

Thank you very much! 🤗

@lastzero lastzero added help wanted Well suited for external contributors! ux Impacts User Experience needs-analysis Requires further investigation and removed bug Something isn't working labels Jul 13, 2023
@lastzero lastzero changed the title UX: on Chrome, back and forward buttons of mouse are hijacked to "drag/zoom" function when viewing an image UX: The "Back" and "Forward" buttons of the mouse are misused for "Drag/Zoom" when viewing an image in Google Chrome Jul 13, 2023
@fireattack
Copy link
Author

It looks like it has been reported by others there:

dimsemenov/PhotoSwipe#1743
dimsemenov/PhotoSwipe#1604

Since ver.4 is no longer updated, one has to fix the bug themselves, such as in this fork andi34/PhotoSwipe@bffac8f.

(I don't encounter the bug in ver. 5 demo they have.)

@lastzero
Copy link
Member

Thank you very much, that is very helpful! Would it be acceptable for you if we fix this at a later time, for example when working on our new media viewer?

We need to focus on merging the open pull requests next and should then take care of important security related issues like 2FA, leaving little time to work on UX issues in the short term. We also shouldn't use a fork without having time to test it well.

@lastzero lastzero added frontend Requires experience with HTML/JS/CSS and removed needs-analysis Requires further investigation labels Jul 13, 2023
@lastzero lastzero moved this to Upcoming ⏳ in Roadmap 🚀✨ Jul 13, 2023
@fireattack
Copy link
Author

Yeah no problem, take your time.

@armribdev
Copy link

So, does this feature wait for the new media viewer? I saw that a lot of small fixes and enhancements are opened for the media viewer and all of these should better be fixed in the new media viewer. I would be happy to work on this home-made viewer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Requires experience with HTML/JS/CSS help wanted Well suited for external contributors! ux Impacts User Experience
Projects
Status: Upcoming
Development

No branches or pull requests

3 participants