Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix dac cue setup and upgrade min version #2255

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[BUGFIX] Fix dac cue setup and upgrade min version #2255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/cli/cmd/dac/setup/cue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func extractCUEDepsToDst() error {

switch header.Typeflag {
case tar.TypeDir:
if folderErr := os.Mkdir(newDepPath, 0666); err != nil {
if folderErr := os.Mkdir(newDepPath, os.ModePerm); err != nil {
return fmt.Errorf("can't create dir %s: %v", newDepPath, folderErr)
}
logrus.Debugf("dir %s created succesfully", newDepPath)
Expand Down
2 changes: 1 addition & 1 deletion internal/cli/cmd/dac/setup/setup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import (
)

const (
minVersion = "v0.44.0-rc0" // TODO upgrade this number once DaC CUE SDK is released
minVersion = "v0.47.0"
cueLanguage = "cue"
goLanguage = "go"
)
Expand Down
2 changes: 1 addition & 1 deletion internal/cli/cmd/dac/setup/setup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func TestDacSetupCMD(t *testing.T) {
Title: "too-old Perses version submitted",
Args: []string{"--version", "0.42.1"},
IsErrorExpected: true,
ExpectedMessage: "version should be at least v0.44.0-rc0 or higher",
ExpectedMessage: "version should be at least v0.47.0 or higher",
},
}
cmdTest.ExecuteSuiteTest(t, NewCMD, testSuite)
Expand Down
Loading