Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbols for each column #27

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Symbols for each column #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Symbols for each column 
I crosschecked the symbols with a purple pen and it seems like kind match column for all columns except column E which contains both kind E and D. I changed from all symbols to what I hope are the correct symbols for each column.

There was an issue with svg-control-descriptions. Symbol "bend" was assigned to wrong kind in lang.json.
  • Loading branch information
@wlfrdssn
wlfrdssn authored Dec 27, 2024
commit 70089520a3da42a893c2ec68c3e5918a3df9f56d
14 changes: 7 additions & 7 deletions src/ControlDescriptionSheet.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,14 +232,14 @@ function DescriptionSelector({

function DescriptionList({ selected, onSelect, column }) {
const symbols = useMemo(() => {
const symbols = Object.keys(DefinitionTexts);
const symbols = Object.keys(DefinitionTexts).filter((key) => {
if (column === "E") {
return DefinitionTexts[key].kind === "E" || DefinitionTexts[key].kind === "D";
}
return DefinitionTexts[key].kind === column;
});
symbols.sort((a, b) => {
const aDef = DefinitionTexts[a];
const bDef = DefinitionTexts[b];
const aIsCol = aDef.kind === column ? -1 : 1;
const bIsCol = bDef.kind === column ? -1 : 1;

return compare(aIsCol, bIsCol) || compare(a, b);
return compare(a, b);
});
return symbols;
}, [column]);
Expand Down