Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix normal control after finish control #25

Merged
merged 1 commit into from
Dec 27, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Bugfix normal control after finish control
Fixed a bug that allowed a normal control to be set after the finish control was placed.
  • Loading branch information
wlfrdssn authored Dec 26, 2024
commit 6cf823c92d8b198d0743e052d28044c118d1e33c
9 changes: 9 additions & 0 deletions src/tools/CreateCourse.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,15 @@ export default function CreateCourse(): JSX.Element {
addControl({ ...control }, selectedCourseId);
} else {
const numberControls = controlsSource.getFeatures().length;

const hasFinishControl = controlsSource.getFeatures().some(
(feature) => feature.get("kind") === "finish"
);

if (hasFinishControl) {
return;
}

const kind =
activeModeRef.current === "Finish"
? "finish"
Expand Down