Bugfix reuse control

There was a bug that allowed a normal or finish control to be used as the start control when reusing a control. I have separated them so that 'start' can only be reused with 'start,' 'normal' with 'normal,' and 'finish' with 'finish.'
perliedman · Dec 26, 2024 · 888c504 · 888c504
1 parent 59c9140
commit 888c504
Showing 1 changed file with 27 additions and 0 deletions.
diff --git a/src/tools/CreateCourse.tsx b/src/tools/CreateCourse.tsx
@@ -192,11 +192,37 @@ export default function CreateCourse(): JSX.Element {
         map.un("pointermove", onPointerMove);
       };
     }
+
+
 
     async function onPointerMove(e: MapBrowserEvent<PointerEvent>) {
       const features = await otherControlsLayer.getFeatures(e.pixel);
       if (features.length > 0) {
         const [feature] = features;
+
+        const controlKind = feature.get("kind");
+
+        const numberControls = controlsSource?.getFeatures().length || 0;
+
+        let expectedKind: "start" | "normal" | "finish";
+
+        if (numberControls === 0) {
+          expectedKind = "start";
+        } else if (activeModeRef.current === "Finish") {
+          expectedKind = "finish";
+        } else {
+          expectedKind = "normal";
+        }
+
+        if (controlKind !== expectedKind) {
+          if (highlightFeatureRef.current) {
+            const previousHighlight = highlightFeatureRef.current;
+            highlightFeatureRef.current = undefined;
+            previousHighlight.changed();
+          }
+          return;
+        }
+
         if (feature !== highlightFeatureRef.current) {
           highlightFeatureRef.current = feature;
           feature.changed();
@@ -261,3 +287,4 @@ function getEvent({
     addControl,
   };
 }
+