-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated include of L.Mixin.Events #425
Comments
Indeed. I even added that message to Leaflet myself: Leaflet/Leaflet#5365 😃 I haven't had much time to work on Leaflet Routing Machine lately, but this is definitely something I should look at. I would guess it's a little bit involved, though, since I expect this to break compatibility with Leaflet 0.7, so it would probably have to be a Leaflet Routing Machine version 4.0. |
I have this also and some more plugins threw this warning. In my case it is for example the Leaflet.draw 0.4.9 and the Control.Geocoder 1.5.4. |
Would love to see a version 4.0. |
As the routing machine includes Events in four places, the javascript console produces four deprecation warnings perliedman#425
* Remove deprecation warning due to including L.Mixin.Events As the routing machine includes Events in four places, the javascript console produces four deprecation warnings #425 * add a check to ensure L.Evented exists before accessing it's prototype else on older versions of Leaflet which don't have L.Evented, an exception will be raised when accessing the prototype of a null object.
My PR - #445 means this issue can be closed - @perliedman is it worth doing a release do you think? 3.2.8? (and thanks for accepting the PR in the end!) |
Yes, closing this. I should do a 3.2.8 release, but it might take a while to find the time to do it. |
Hey @perliedman, maybe re open this one until the 3.2.8 release is out? |
Any idea when this v3.2.8 will be released? |
FYI, I released 3.2.8 just now. |
I'm currently working on a small react project and getting warnings about:
Deprecated include of L.Mixin.Events: this property will be removed in future releases, please inherit from L.Evented instead.
from leaflet. It looks like this plugin is using something that's deprecated or in the process of being so.The package versions I'm using are:
"leaflet": "1.2.0"
"leaflet-routing-machine": "3.2.5"
Thanks in advance :)
The text was updated successfully, but these errors were encountered: