Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated include of L.Mixin.Events #425

Closed
3 tasks done
alterx opened this issue Aug 9, 2017 · 8 comments
Closed
3 tasks done

Deprecated include of L.Mixin.Events #425

alterx opened this issue Aug 9, 2017 · 8 comments

Comments

@alterx
Copy link

alterx commented Aug 9, 2017


I'm currently working on a small react project and getting warnings about:
Deprecated include of L.Mixin.Events: this property will be removed in future releases, please inherit from L.Evented instead. from leaflet. It looks like this plugin is using something that's deprecated or in the process of being so.

The package versions I'm using are:
"leaflet": "1.2.0"
"leaflet-routing-machine": "3.2.5"

Thanks in advance :)

@perliedman
Copy link
Owner

Indeed. I even added that message to Leaflet myself: Leaflet/Leaflet#5365 😃

I haven't had much time to work on Leaflet Routing Machine lately, but this is definitely something I should look at. I would guess it's a little bit involved, though, since I expect this to break compatibility with Leaflet 0.7, so it would probably have to be a Leaflet Routing Machine version 4.0.

@CmdSec
Copy link

CmdSec commented Aug 16, 2017

I have this also and some more plugins threw this warning. In my case it is for example the Leaflet.draw 0.4.9 and the Control.Geocoder 1.5.4.

@muenchhagen
Copy link

Would love to see a version 4.0.
My solution so far is to turn off the warnings. But my heart breaks doing so.

jamesjefferies added a commit to jamesjefferies/leaflet-routing-machine that referenced this issue Nov 2, 2017
As the routing machine includes Events in four places, the javascript
console produces four deprecation warnings
perliedman#425
perliedman pushed a commit that referenced this issue Nov 3, 2017
* Remove deprecation warning due to including L.Mixin.Events
As the routing machine includes Events in four places, the javascript
console produces four deprecation warnings
#425

* add a check to ensure L.Evented exists before accessing it's prototype
else on older versions of Leaflet which don't have L.Evented, an exception will be raised when accessing the prototype of a null object.
@jamesjefferies
Copy link
Contributor

My PR - #445 means this issue can be closed - @perliedman is it worth doing a release do you think? 3.2.8? (and thanks for accepting the PR in the end!)

@perliedman
Copy link
Owner

Yes, closing this.

I should do a 3.2.8 release, but it might take a while to find the time to do it.

@alterx
Copy link
Author

alterx commented Dec 29, 2017

Hey @perliedman, maybe re open this one until the 3.2.8 release is out?

@Berkmann18
Copy link

Any idea when this v3.2.8 will be released?

@perliedman
Copy link
Owner

FYI, I released 3.2.8 just now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants