-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove testify #872
Comments
Hi, I would like to take this issue |
I'd be happy to review a pull request :) |
@ramisback Are you still planning to work on this? |
Hey @pelletier 👋 I can see a couple of approaches - either (manually) vendorize |
Hi! I think it would be better to re-implement the minimal subset needed instead of vendoring (which would also bring the dependencies). Looking at the current use of testify in this project:
I'd follow something like this. First, pick one of
Which is only 12 functions, most of them straightforward to write, or lightly adapted from testify. Then once all the testify calls are all mapped, create an I believe the hard part will be printing the diff when two values differ. Though I think a simple |
The only dependency of go-toml v2 is
stretchr/testify
, which itself imports a bunch of stuff. I'd like this library to be dependence-free. The test suite only uses a few functions from testify, so it should be reasonably straightforward to implement them inside go-toml and replace the import statements.Maybe they can be stored in
/internal/require
and/internal/assert
to preserve the same layout.The text was updated successfully, but these errors were encountered: