Centroid computation for relations in some cases broken #96
Labels
Comments
|
Thanks for the thoughtful bug report. You're right, the polygon centroid calculations could be improved, would you be able to help out on this, I don't have a lot of time to work on it right now? In that case specifically there is also a member node with the role
|
This was referenced Jul 21, 2021
|
This doesn't address the issue mentioned in the description, but it was an easy fix and would fix the Hamburg relation centroid and any other relation which has a node of role 'admin_centre': #98 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Currently, centroids of relations are being calculated by detecting the largest area and calculating the centroid of it. This is broken for some relations, since members of relation-type
outercannot always be seen as one shape. For Hamburg there are multiple way objects that are describing the border. Choosing the largest area therefore is not helpful here.Steps to Reproduce
Dataset: https://download.geofabrik.de/europe/germany/hamburg.html
Expected behavior
Detecting relation members as closed or open ways. If closed => calculate centroid, if open => create polygon out of them and compute centroid. Also, administrative relations have a
admin_centremember, that could be used as a centroid.Pastebin/Screenshots
Calculated centroid of Hamburg
Actual centroid of Hamburg
The text was updated successfully, but these errors were encountered: