Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old pre-built binary versions #89

Open
hyperknot opened this issue Apr 20, 2020 · 2 comments
Open

Old pre-built binary versions #89

hyperknot opened this issue Apr 20, 2020 · 2 comments
Labels
enhancement

Comments

@hyperknot
Copy link

hyperknot commented Apr 20, 2020 •
edited
Loading

Use-cases

The user should be able to figure out:

  • How to get the latest pre-built binary
  • What is the version number of a given pre-built binary

Attempted Solutions

I looked at GitHub / master branch, where:

  • releases say latest version is 6.5.0
  • the build folder contains files from 10 month ago, so it cannot be 6.5.0, but not even 6.4.0. Probably they are from 6.3.0
  • I tried to run --version and --help on them, but it was not possible to see the version in any way
  • I tried downloading from npm, again, I had no idea what binary version is included there.

Proposal

  • Document the above points
  • Add a --version switch so that it's clear what version is a given pre-built binary.
@hyperknot hyperknot changed the title Document pre-built binary versions Old pre-built binary versions Apr 20, 2020
@hyperknot
Copy link
Author

Update: I did a binary compare on npm's build and github master's build, they are the same file. So it seems that both versions are really old, around 6.3.0.

@missinglink
Copy link
Member

missinglink commented Apr 20, 2020 •
edited
Loading

Yes, I think the confusion is that the Go code and the JavaScript code are developed independently.

We use semantic-release for our version of npm so the minor version has incremented twice since the latest Go code changes in #82. (one per commit prefixed with feat():)

Regarding your use-case, the latest version of the npm module will always include the latest version of the go code and the latest binary published on GitHub will always include the latest Go code.

Adding a version switch to the Go binary would be a nice addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hyperknot @missinglink