Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: fix region to work properly if bucket is specified #355

Closed
wants to merge 1 commit into from

Conversation

sihara
Copy link

@sihara sihara commented Sep 20, 2021

This is fix for Issue #354. custom region can be worked, but when if bucket is not specified.
Fix solves problem and user defined region works regardless bucket is specified.

This is fix for Issue peak#354. custom region can be worked, but when if bucket is not specified.
Fix solves problem and user defined region works regardless bucket is specified.
@sihara sihara requested a review from a team as a code owner September 20, 2021 04:59
@sihara sihara requested review from igungor and sonmezonur and removed request for a team September 20, 2021 04:59
@seruman
Copy link
Member

seruman commented Sep 20, 2021

Thanks for the PR @sihara. As I've mentioned in #354 (comment) there's an open PR #331 to address region detection issue, which we both made similar changes apparently 🙂. We're planning to release it in the following months with the new major release.

Closing for #331

@seruman seruman closed this Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants