Improve Linux experience for crank run --device
#36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some of the comments in #12.
modem_path
to disappear after initiating data disk mode, since (at least for me) it remains available.pdutil run
. Without a wait it was failing. I based this on the Windows case, but on my machine it required 1s instead of 500ms.For the last two items, I chose a
println
rather than a log message because logging isn't enabled in crank by default - I didn't want to change the logging strategy and thought these would be helpful for newer users/developers.I confirmed that the simulator case still worked as expected, with no changes, and that the changes worked as described with
--device
.(The eject error is a separate issue mentioned in #12.)
These changes are in the
cfg(unix)
path, and so also affect Mac, but I don't have a Mac setup to test with - hoping for confirmation there.