Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consolidates logic in update and updateByID operations #9998

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

feat: consolidates logic in update and updateByID operations #9998

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ff30d1e
feat: consolidates duplicative logic between update and updateByID op…
JarrodMFlesch Dec 16, 2024
ebedfb4
chore: cleanup, await update in update many
JarrodMFlesch Dec 16, 2024
d635370
chore: remove duplicative spread
JarrodMFlesch Dec 17, 2024
2c12a06
chore: move unlink files call
JarrodMFlesch Dec 17, 2024
ff477d7
fix: shouldSaveDraft argument should also look at data._status argument
JarrodMFlesch Dec 17, 2024
2a9c209
chore: do not use fallbackLocale when querying original doc in update…
JarrodMFlesch Jan 8, 2025
f790b48
fix: adust usage of fallbackLocale in updateByID
JarrodMFlesch Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove duplicative spread
  • Loading branch information
@JarrodMFlesch
JarrodMFlesch committed Dec 17, 2024
commit d63537089581fe3a8bf46a8ff1f08105aad20862
6 changes: 1 addition & 5 deletions packages/payload/src/collections/operations/update.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ export const updateOperation = async <
// Generate data for all files and sizes
// /////////////////////////////////////

const { data: newFileData, files: filesToUpload } = await generateFileData({
const { data, files: filesToUpload } = await generateFileData({
collection,
config,
data: bulkUpdateData,
Expand All @@ -179,10 +179,6 @@ export const updateOperation = async <

const promises = docs.map(async (docWithLocales) => {
const { id } = docWithLocales
const data = {
...newFileData,
...bulkUpdateData,
}

try {
// ///////////////////////////////////////////////
Expand Down
Loading