Updates based on code review

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
patrick-othmer · Feb 2, 2022 · 279ec83 · 279ec83
1 parent 05a456d
commit 279ec83
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/js_test.go b/js_test.go
@@ -81,6 +81,7 @@ func createConfFile(t *testing.T, content []byte) string {
 }
 
 func shutdownJSServerAndRemoveStorage(t *testing.T, s *server.Server) {
+	t.Helper()
 	var sd string
 	if config := s.JetStreamConfig(); config != nil {
 		sd = config.StoreDir

diff --git a/nats_test.go b/nats_test.go
@@ -137,10 +137,6 @@ func TestExpandPath(t *testing.T) {
 			{path: "/Foo/Bar", userProfile: `C:\Foo\Bar`, wantPath: "/Foo/Bar"},
 			{path: "Foo/Bar", userProfile: `C:\Foo\Bar`, wantPath: "Foo/Bar"},
 			{path: "~/Fizz", userProfile: `C:\Foo\Bar`, wantPath: `C:\Foo\Bar\Fizz`},
-			// That one would fail because expandPath(), if not finding `~` returns
-			// the given path, which since ${HOMEDRIVE}${HOMEPATH} is not set,
-			// would return `\Fizz` but test expects `C:\Foo\Bar\Fizz`?
-			// {path: `${HOMEDRIVE}${HOMEPATH}\Fizz`, userProfile: `C:\Foo\Bar`, wantPath: `C:\Foo\Bar\Fizz`},
 
 			// Missing USERPROFILE.
 			{path: "~/Fizz", homeDrive: "X:", homePath: `\Foo\Bar`, wantPath: `X:\Foo\Bar\Fizz`},

diff --git a/test/js_test.go b/test/js_test.go
@@ -36,6 +36,7 @@ import (
 )
 
 func shutdownJSServerAndRemoveStorage(t *testing.T, s *server.Server) {
+	t.Helper()
 	var sd string
 	if config := s.JetStreamConfig(); config != nil {
 		sd = config.StoreDir