Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-commit hooks for pyright and mypy (only API tests) #283

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Pre-commit hooks for pyright and mypy (only API tests) #283

merged 4 commits into from
Jan 8, 2025

Conversation

z4m0
Copy link
Contributor

@z4m0 z4m0 commented Jan 3, 2025

Fixes #275.

@z4m0 z4m0 mentioned this pull request Jan 3, 2025
Closed
patrick-kidger
patrick-kidger reviewed Jan 4, 2025
View reviewed changes
Copy link
Owner

@patrick-kidger patrick-kidger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits aside, this LGTM! Thank you very much for contributing.

(I also am not a mypy user and don't know how to adjust it... I'm sure it's fine as-is :) )

test/types/decorator.py Outdated Show resolved Hide resolved
test/types/decorator.py Outdated Show resolved Hide resolved
@patrick-kidger patrick-kidger merged commit 7d25a6b into patrick-kidger:main Jan 8, 2025
2 checks passed
@patrick-kidger
Copy link
Owner

Alright, LGTM! (I tweaked the pre-commit config slightly to make it work in CI.)

Thank you for contributing -- merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick-kidger patrick-kidger patrick-kidger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dataclasses static types not working in pyright/pylance since version 0.2.35
2 participants
@z4m0 @patrick-kidger