Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop packaging test files with the gem #100

Merged
merged 1 commit into from
May 16, 2017
Merged

Stop packaging test files with the gem #100

merged 1 commit into from
May 16, 2017

Conversation

dmeremyanin
Copy link
Contributor

It drastically reduces the size of the gem, from 1.9M to 32K. The default for new gems (created by bundler) is not to include test files. See rubygems/bundler#3207

@dmeremyanin
Stop packaging test files with the gem
07ea54d 
It drastically reduces the size of the gem, from 1.9M to 32K. The
default for new gems (created by bundler) is not to include test files.
See rubygems/bundler#3207
@pat pat merged commit 1da09b0 into pat:develop May 16, 2017
@pat
Copy link
Owner

pat commented May 16, 2017

I'm sure I'd done this at some point previously, but then I've obviously screwed it up again. Thanks for the fix!

@dmeremyanin
Copy link
Contributor Author

My pleasure, @pat! Thanks for the quick merge.

@bibendi
Copy link

bibendi commented May 16, 2017

But if you use thoughtbot/factory_girl and have a dev dependency in other gem that uses them - it will be a big surprise 😄

@pat pat mentioned this pull request Dec 7, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmeremyanin @pat @bibendi