Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove generated symbol tests #75

Open
alancai98 opened this issue Apr 7, 2023 · 1 comment
Open

Remove generated symbol tests #75

alancai98 opened this issue Apr 7, 2023 · 1 comment

Comments

@alancai98
Copy link
Member

Currently the conformance tests include some tests with generated symbol names following the convention partiql-lang-kotlin and the spec use (using _1, _2,...).

The spec states in section 6.3.1 that

SQL and PartiQL do not provide a standard convention

Since there's no mention of the actual generated names, these conformance tests should be removed or moved to the "extended" directory of tests.
@alancai98
Copy link
Member Author

Tests not explicitly testing the generated name (example test) should probably add aliases so the generated symbols aren't necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alancai98