Don't fail when API endpoint returns 500

parroty · Jun 30, 2022 · 6da230e · 6da230e
1 parent a215645
commit 6da230e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/lib/excoveralls/poster.ex b/lib/excoveralls/poster.ex
@@ -43,6 +43,8 @@ defmodule ExCoveralls.Poster do
       {:ok, status_code, _, _} when status_code in 200..299 ->
         {:ok, "Successfully uploaded the report to '#{endpoint}'."}
 
+      {:ok, 500 = _status_code, _, _client} ->        
+        {:ok, "API endpoint `#{endpoint}` is not available and return internal server error! Ignoring upload"}
       {:ok, status_code, _, client} ->
         {:ok, body} = :hackney.body(client)
 

diff --git a/test/poster_test.exs b/test/poster_test.exs
@@ -21,4 +21,15 @@ defmodule PosterTest do
       assert ExCoveralls.Poster.execute("json") == :ok
     end) =~ ~r/timeout/
   end
+  test_with_mock "post json fails due internal server error", :hackney, [request: fn(_, _, _, _, _) -> {:ok, 500, "", ""} end] do
+    assert capture_io(fn ->
+      assert ExCoveralls.Poster.execute("json") == :ok
+    end) =~ ~r/internal server error/
+  end
+
+  test_with_mock "post json fails due to maintenance", :hackney, [request: fn(_, _, _, _, _) -> {:ok, 405, "", ""} end] do
+    assert capture_io(fn ->
+      assert ExCoveralls.Poster.execute("json") == :ok
+    end) =~ ~r/maintenance/
+  end
 end