Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

approval-distribution: batched approval/assignment sending #6401

Merged
merged 12 commits into from
Dec 13, 2022
Merged

approval-distribution: batched approval/assignment sending #6401

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
32d2ab8
Imple batched send
sandreim Dec 6, 2022
a938c47
Add batch tests
sandreim Dec 6, 2022
0e81e4f
pub MAX_NOTIFICATION_SIZE
sandreim Dec 6, 2022
27668d9
spell check
sandreim Dec 6, 2022
b26f42d
spellcheck ...
sandreim Dec 6, 2022
da40262
Fix comment
sandreim Dec 6, 2022
1840ae2
o.O
sandreim Dec 6, 2022
8fd2ae6
2 constants
sandreim Dec 12, 2022
4525c1e
Ensure batch size is at least 1 element
sandreim Dec 12, 2022
ff23cb9
feedback impl
sandreim Dec 12, 2022
e5782dc
Merge branch 'master' of github.com:paritytech/polkadot into sandreim…
sandreim Dec 12, 2022
668436b
Merge branch 'master' of github.com:paritytech/polkadot into sandreim…
sandreim Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
spellcheck ... 
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
  • Loading branch information
@sandreim
sandreim committed Dec 6, 2022
commit b26f42d3a2aa5892aea2b9c5570458029459269d
2 changes: 1 addition & 1 deletion node/network/approval-distribution/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1768,7 +1768,7 @@ pub(crate) async fn send_assignments_batched(
}
}

/// Send approvals while honouring the `max_notification_size` of the protocol.
/// Send approvals while honoring the `max_notification_size` of the protocol.
pub(crate) async fn send_approvals_batched(
sender: &mut impl overseer::ApprovalDistributionSenderTrait,
approvals: Vec<IndirectSignedApprovalVote>,
Expand Down