Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Refactoring to condense disputes tests #6395

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Refactoring to condense disputes tests #6395

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c3784ce
Refactoring to condense disputes tests
BradleyOlson64 Dec 5, 2022
fcc09f9
Removing unhelpful comment lines
BradleyOlson64 Dec 5, 2022
4128694
Addressing Tsveto's suggestions
BradleyOlson64 Dec 6, 2022
2ce9924
Fixing formatting nit
BradleyOlson64 Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removing unhelpful comment lines
  • Loading branch information
@BradleyOlson64
BradleyOlson64 committed Dec 5, 2022
commit fcc09f9f1b2c721e9aaa58e5034bf9cbc5f4479b
4 changes: 0 additions & 4 deletions node/core/dispute-coordinator/src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,6 @@ async fn overseer_recv(virtual_overseer: &mut VirtualOverseer) -> AllMessages {

/// Helper to condense repeated code that creates vote pairs, one valid and one
/// invalid. Optionally the valid vote of the pair can be made a backing vote.
///
/// Parameters valid_voter_idx, invalid_voter_idx, candidate_hash, session,
/// test_state, valid_is_backing
/// Returns tuple containing valid then invalid vote
async fn generate_vote_pair(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about generate_opposing_votes_pair?

test_state: &TestState,
valid_voter_idx: ValidatorIndex,
Expand Down