Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Let the PVF host kill the worker on timeout #6381

Merged
merged 5 commits into from
Dec 6, 2022
Merged

Let the PVF host kill the worker on timeout #6381

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79cc6ff
Let the PVF host kill the worker on timeout
mrcnski Dec 2, 2022
f035999
Fix comment
mrcnski Dec 2, 2022
4b85076
Fix inaccurate comments; add missing return statement
mrcnski Dec 2, 2022
d0d0c18
Fix a comment
mrcnski Dec 2, 2022
1ee8695
Fix comment
mrcnski Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix comment
  • Loading branch information
@mrcnski
mrcnski committed Dec 2, 2022
commit f03599961b3aed6b8785491d19c7e796ccfdef1d
4 changes: 2 additions & 2 deletions node/core/pvf/src/prepare/worker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,8 @@ pub async fn start_work(

/// Handles the case where we successfully received response bytes on the host from the child.
///
/// NOTE: Here we know the artifact exists, but is still located in a temporary file. If we error, the temporary
/// artifact will be cleared by `with_tmp_file`.
/// NOTE: Here we know the artifact exists, but is still located in a temporary file which will be
/// cleared by `with_tmp_file`.
async fn handle_response_bytes(
response_bytes: Vec<u8>,
pid: u32,
Expand Down