This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add buckets on lower end of distribution to network bridge latency metrics #6359
Merged
sandreim
merged 6 commits into
master
from
bredamattia/network-bridge-metrics-granularity
Dec 2, 2022
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9a409d4
Add two more buckets on lower end of distribution
bredamatt 8c3fc70
Merge branch 'master' of github.com:paritytech/polkadot into bredamat…
bredamatt 11e0532
add even smaller buckets
bredamatt ca91997
Merge branch 'master' of github.com:paritytech/polkadot into bredamat…
bredamatt c8f10a4
cargo fmt
bredamatt 73f2bf6
Merge branch 'master' of github.com:paritytech/polkadot into bredamat…
bredamatt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add even smaller buckets
- Loading branch information
commit 11e05329f3bdb062042a08fffd0088d4198491f5
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally these buckets don't make a big difference, but I am interested in seeing if they do in a more realistic scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some realistic values I would look at some historical data from Versi. Even if we don't have these buckets, the sum and count of samples allow us to compute some average value which could be used to estimated some good buckets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!