This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Introduce NIS functionality into Kusama/Rococo #6352
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a1b7d9f
Integrate NIS into Kusama/Rococo
gavofyork dca396f
Missing files
gavofyork cb05063
Merge remote-tracking branch 'origin/master' into gav-ref-nis
gavofyork fbc74fd
Fix
gavofyork 23431e9
Fix
gavofyork a2209b9
Formatting
gavofyork dba2d84
Add Kusama weights
ggwpez 7297e2d
Add Rococo weights
ggwpez f17dd45
Use weights
ggwpez 22f6ad9
Merge remote-tracking branch 'origin/master' into gav-ref-nis
gavofyork 1b78882
Bump
gavofyork 99f6cdc
Bump
gavofyork 943f9a7
".git/.scripts/bench-bot.sh" runtime kusama-dev pallet_nis
d15e1c2
".git/.scripts/bench-bot.sh" runtime rococo-dev pallet_nis
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand the instantiation macro correctly, other mentions of
pallet_balances
without a declared instance (e.g. in the frame system config) will know that those refer to thepallet_balances::Config
without an explicitInstance
and not this one?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this will work properly. It's best to explicitly specify pallet instances when there are more than one though.