Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Only report concluded if there is an actual dispute. #6270

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Only report concluded if there is an actual dispute. #6270

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d86209
Only report concluded if there is an actual dispute.
Nov 11, 2022
62d919d
Fix redundant check.
Nov 14, 2022
de07e15
Test for no onesided disputes.
Nov 14, 2022
b503024
Merge branch 'master' into rk-fix-onesided-disputes
Nov 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix redundant check.
  • Loading branch information
eskimor committed Nov 14, 2022
commit 62d919d38757f443da80a5253a442c286ded9a78
2 changes: 1 addition & 1 deletion node/core/dispute-coordinator/src/import.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ impl CandidateVoteState<CandidateVotes> {
let dispute_status = if is_disputed {
let mut status = DisputeStatus::active();
let byzantine_threshold = polkadot_primitives::v2::byzantine_threshold(n_validators);
let is_confirmed = votes.voted_indices().len() > byzantine_threshold && is_disputed;
let is_confirmed = votes.voted_indices().len() > byzantine_threshold;
if is_confirmed {
status = status.confirm();
};
Expand Down