Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Make some fixes to logging in PVF subsystem #6180

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Make some fixes to logging in PVF subsystem #6180

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39879c5
Log exit status code for workers
mrcnski Oct 23, 2022
392c315
Make log for execute job conclusion match prepare job conclusion
mrcnski Oct 23, 2022
3a16278
Merge remote-tracking branch 'origin/master' into m-cat/pvf-logging-f…
Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Make log for execute job conclusion match prepare job conclusion 
Trace log for conclusion of prepare job:

```rs
gum::debug!(
	target: LOG_TARGET,
	validation_code_hash = ?artifact_id.code_hash,
	?worker,
	?rip,
	"prepare worker concluded",
);
```
  • Loading branch information
@mrcnski
mrcnski committed Oct 23, 2022
commit 392c31526cbeb6fc67adaceed93430df18042911
6 changes: 3 additions & 3 deletions node/core/pvf/src/execute/queue.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,12 +244,12 @@ fn handle_job_finish(
};

queue.metrics.execute_finished();
gum::trace!(
gum::debug!(
target: LOG_TARGET,
validation_code_hash = ?artifact_id.code_hash,
?worker,
worker_rip = idle_worker.is_none(),
?result,
"job finished.",
"execute worker concluded",
);

// First we send the result. It may fail due the other end of the channel being dropped, that's
Expand Down