This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
node/service/src/lib: Do not spawn authority discovery on sentries #1835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The notion of sentry nodes has been deprecated (see [1] for details). Support for sentry nodes in the `client/authority-discovery` module has been removed. This commit adjusts the instantiation of the authority discovery worker accordingly, only spawning the module on authority nodes. [1] paritytech/substrate#6845
mxinden
added
A0-please_review
ordian
approved these changes
Oct 21, 2020
There was a problem hiding this comment.
Looks good, but this will conflict with #1795 (cc @coriolinus). I'm fine with merging this PR first as it is smaller.
|
Waiting for commit status. |
ghost
merged commit 
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The notion of sentry nodes has been deprecated (see [1] for details).
Support for sentry nodes in the
client/authority-discoverymodule hasbeen removed.
This commit adjusts the instantiation of the authority discovery worker
accordingly, only spawning the module on authority nodes.
Companion for paritytech/substrate#7368.
[1] paritytech/substrate#6845