Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL: Specify UTF-8 charset for versions table #681

Merged
merged 1 commit into from
Dec 27, 2015

Conversation

jaredbeck
Copy link
Member

Fixes #651

This change configures MySQL to use UTF-8 for the versions table.

Even modern versions of MySQL still use latin1 as the default character
encoding. (https://dev.mysql.com/doc/refman/5.7/en/charset-applications.html)
Many users are not aware of this, and run into trouble when they try to use
PaperTrail in apps that otherwise tend to use UTF-8. Postgres, by
comparison, uses UTF-8 except in the unusual case where the OS is configured
with a custom locale (http://www.postgresql.org/docs/9.4/static/multibyte.html).

@carsonreinke
Copy link

Should this be utf8mb4 for the object column instead?

@jaredbeck jaredbeck force-pushed the fix_651_mysql_charset branch from 1ff9194 to d03d446 Compare December 27, 2015 22:42
@jaredbeck
Copy link
Member Author

Should this be utf8mb4 for the object column instead?

Interesting. Yes, I think so. This means dropping support for MySQL < 5.5.3, but I'm OK with that. MySQL 5.5.3 was released on 2010-03-24.

@jaredbeck jaredbeck force-pushed the fix_651_mysql_charset branch from d03d446 to d138b95 Compare December 27, 2015 22:59
jaredbeck added a commit that referenced this pull request Dec 27, 2015
MySQL: Specify UTF-8 charset for versions table
@jaredbeck jaredbeck merged commit eef918b into master Dec 27, 2015
@jaredbeck jaredbeck deleted the fix_651_mysql_charset branch December 27, 2015 23:45
@jaredbeck
Copy link
Member Author

Thanks Carson.

@carsonreinke
Copy link

Glad to hear I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants