Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python codegen for the OpenAPI backend #21316

Merged
merged 21 commits into from
Dec 22, 2024
Merged

Support Python codegen for the OpenAPI backend #21316

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
e0dd5dd
Copy openapi java stuff
grihabor Aug 10, 2024
14a9762
Implement python codegen
grihabor Aug 11, 2024
4343919
Change package structure
grihabor Aug 17, 2024
f5a3caa
Implement package_mapper
grihabor Aug 17, 2024
22d4f6a
One test works
grihabor Aug 17, 2024
581a51c
Some tests works
grihabor Aug 17, 2024
dc0a03a
Tests pass
grihabor Aug 17, 2024
b9973a3
pants fix
grihabor Aug 17, 2024
4d6eb01
Fix mypy
grihabor Aug 17, 2024
b854cc1
pants fix
grihabor Aug 18, 2024
5899574
Add notes
grihabor Aug 18, 2024
12730a0
Set 2024
grihabor Aug 18, 2024
6006a84
Use itertools.product
grihabor Aug 18, 2024
4e9904e
Update notes
grihabor Aug 18, 2024
ee0a9bc
Update year
grihabor Aug 18, 2024
cc480a7
Revert notes
grihabor Dec 21, 2024
350d3fd
Merge branch 'main' into openapi-python
grihabor Dec 21, 2024
47228fe
Add a test for python-fastapi generator
grihabor Dec 21, 2024
e25726d
Add test_openapi_generator_name_validation
grihabor Dec 21, 2024
3e882ed
Add notes
grihabor Dec 21, 2024
2ec8ea2
Merge branch 'main' into openapi-python
alonsodomin Dec 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix mypy
  • Loading branch information
@grihabor
grihabor committed Aug 17, 2024
commit 4d6eb01f3b7d7a548fe90bb5ab49b10362870690
6 changes: 1 addition & 5 deletions src/python/pants/backend/openapi/codegen/python/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@

python_sources()

python_tests(
name="tests",
dependencies=[":lockfiles"],
timeout=600,
)
python_tests(name="tests", dependencies=[":lockfiles"])

resources(name="lockfiles", sources=["*.test.lock"])
20 changes: 11 additions & 9 deletions src/python/pants/backend/openapi/codegen/python/generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
from pants.backend.openapi.target_types import (
OpenApiDocumentDependenciesField,
OpenApiDocumentField,
OpenApiSourceField,
)
from pants.backend.openapi.util_rules.generator_process import OpenAPIGeneratorProcess
from pants.backend.python.dependency_inference.module_mapper import AllPythonTargets
Expand Down Expand Up @@ -58,6 +59,8 @@
HydrateSourcesRequest,
InferDependenciesRequest,
InferredDependencies,
TransitiveTargets,
TransitiveTargetsRequest,
)
from pants.engine.unions import UnionRule
from pants.source.source_root import SourceRoot, SourceRootRequest
Expand Down Expand Up @@ -168,17 +171,16 @@ async def generate_python_from_openapi(
if field_set.skip.value:
return GeneratedSources(EMPTY_SNAPSHOT)

(document_sources,) = await MultiGet(
(Get(HydratedSources, HydrateSourcesRequest(field_set.source)),)
# Get(TransitiveTargets, TransitiveTargetsRequest([field_set.address])),
(document_sources, transitive_targets) = await MultiGet(
Get(HydratedSources, HydrateSourcesRequest(field_set.source)),
Get(TransitiveTargets, TransitiveTargetsRequest([field_set.address])),
)

document_dependencies = []
# await MultiGet(
# Get(HydratedSources, HydrateSourcesRequest(tgt[OpenApiSourceField]))
# for tgt in transitive_targets.dependencies
# if tgt.has_field(OpenApiSourceField)
# )
document_dependencies = await MultiGet(
Get(HydratedSources, HydrateSourcesRequest(tgt[OpenApiSourceField]))
for tgt in transitive_targets.dependencies
if tgt.has_field(OpenApiSourceField)
)

input_digest = await Get(
Digest,
Expand Down
Loading