Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker_environment target #16752

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Add docker_environment target #16752

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
938e894
Add `docker_environment` target
Eric-Arellano Sep 1, 2022
9525f24
Define a target for experimenting
Eric-Arellano Sep 1, 2022
abd25b3
Actually register the target
Eric-Arellano Sep 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Define a target for experimenting 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
  • Loading branch information
@Eric-Arellano
Eric-Arellano committed Sep 1, 2022
commit 9525f24e99737855de465b5b11ee943312382249
6 changes: 6 additions & 0 deletions BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,9 @@ _local_environment(
# Avoid system Python interpreters, which tend to be broken on macOS.
python_interpreter_search_paths=["<PYENV>"],
)

# Used for experimenting with the new Docker support.
_docker_environment(
name="docker_env",
image="python:3.9",
)
1 change: 1 addition & 0 deletions pants.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ default_env = "//:default_env"
# TODO(#7735): Define `//:macos_local_env` after figuring out why our Build Wheels Mac job is
# failing when this is set:
# https://github.com/pantsbuild/pants/runs/8082954359?check_suite_focus=true#step:9:657
docker = "//:docker_env"

[tailor]
build_file_header = """\
Expand Down