Added nullable Client object to ChangeLogEntry #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors for configurationChanges endpoint
danielabbatt
approved these changes
Jan 21, 2025
|
Agreed, the model schema is unclear at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added nullable object "Client" property to ChangeLogEntry.cs entity to prevent deseralization errors during unit tests (and elsewhere where the "GetOrganizationConfigurationChangesAsync") method is used.
There is no information in the Meraki API about what this should contain (though there are 2 properties "id" (probably an int / string) and type.
All tests ran on 3 organizations I have access to returned as follows, so I have left Client as a nullable object for now.
"client":{"id":null,"type":null}}
Note: relevant unit test passed with this change, and failed beforehand.