Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new icon - subtract join #7132

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: new icon - subtract join #7132

wants to merge 1 commit into from

Conversation

annawhittakermuratt
Copy link

@annawhittakermuratt annawhittakermuratt commented Dec 18, 2024 •
edited
Loading

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

adds the subtract join icon

Reviewers should focus on:

Screenshot

Screenshot 2024-12-18 at 12 12 23

@changelog-app
Copy link

changelog-app bot commented Dec 18, 2024

Generate changelog in packages/icons/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

feat: new icon - subtract join

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

feat: new icon - subtract join

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ryannono
Copy link
Contributor

ryannono commented Dec 18, 2024 •
edited
Loading

I would add some direction to the icon name, ex. Join: Subtract right

Additionally @ggdouglas will comment more on this but you can have this icon export in a single path if in figma you:

  1. Select all layers
  2. Union the layers
  3. Select the newly created "Union" parent layer
  4. Outline stroke of this layer
  5. Flatten the layer
  6. Export

Then you should get something like (granted you'll have to remove fill and size props on the svg):

<svg viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg"> <path fill-rule="evenodd" d="M6.0056 3.10116C4...."/> </svg>

ggdouglas
ggdouglas reviewed Dec 18, 2024
View reviewed changes
resources/icons/16px/subtract-join.svg
<svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg">
<path fill-rule="evenodd" clip-rule="evenodd" d="M4 8C4 6.14529 4.72785 4.40776 6.0056 3.10116C5.68075 3.03483 5.34444 3 5 3C2.23858 3 0 5.23858 0 8C0 10.7614 2.23858 13 5 13C5.34301 13 5.67796 12.9655 6.00155 12.8997C4.73646 11.6111 4 9.86556 4 8ZM11 3C13.7614 3 16 5.23858 16 8C16 10.7614 13.7614 13 11 13C10.6575 13 10.323 12.9656 9.99981 12.8999C11.2643 11.6096 12 9.8646 12 8C12 6.13491 11.2639 4.38952 9.9997 3.10035C10.3223 3.03451 10.6571 3 11 3ZM12.001 4.127C12.6516 5.30526 13 6.63054 13 8C13 9.25507 12.7074 10.473 12.1617 11.568L12 11.873L12.1553 11.8306C13.7402 11.3533 14.9106 9.91921 14.9951 8.19964L15 8C15 6.19252 13.8012 4.66505 12.1553 4.16936L12.001 4.127Z" fill="#5F6B7C"/>
<path fill-rule="evenodd" clip-rule="evenodd" d="M10 7.99946C10 6.36419 9.21496 4.91226 8.0012 4L7.91804 4.06199C6.75033 4.97727 6 6.40075 6 7.99946C6 9.6352 6.78547 11.0875 8.0012 11.9989C9.21496 11.0867 10 9.63474 10 7.99946ZM7.88898 5.48438L7.999 5.35446L8.07238 5.43734C8.66295 6.14432 9 7.04336 9 7.99946L8.99303 8.23722C8.94207 9.10408 8.61374 9.91352 8.07238 10.5616L8 10.6425L7.92844 10.5616C7.33732 9.85508 7 8.95602 7 7.99946C7 7.06486 7.3219 6.18449 7.88898 5.48438Z" fill="#5F6B7C"/>
</svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to @ryannono 's comment on unioning the path, can we also omit the width, height fill and fill/clip-rule attributes from the final SVG?

<svg viewBox="0 0 16 16" xmlns="http://www.w3.org/2000/svg">
<path d="M6.0056 3.10116C4.72785 4.40776 4 6.14529 4 8C4 9.86556 4.73646 11.6111 6.00155 12.8997C5.67796 12.9655 5.34301 13 5 13C2.23858 13 0 10.7614 0 8C0 5.23858 2.23858 3 5 3C5.34444 3 5.68075 3.03483 6.0056 3.10116ZM16 8C16 5.23858 13.7614 3 11 3C10.6571 3 10.3223 3.03451 9.9997 3.10035C11.2639 4.38952 12 6.13491 12 8C12 9.8646 11.2643 11.6096 9.99981 12.8999C10.323 12.9656 10.6575 13 11 13C13.7614 13 16 10.7614 16 8ZM13 8C13 6.63054 12.6516 5.30526 12.001 4.127L12.1553 4.16936C13.8012 4.66505 15 6.19252 15 8L14.9951 8.19964C14.9106 9.91921 13.7402 11.3533 12.1553 11.8306L12 11.873L12.1617 11.568C12.7074 10.473 13 9.25507 13 8ZM8.0012 4C9.21496 4.91226 10 6.36419 10 7.99946C10 9.63474 9.21496 11.0867 8.0012 11.9989C6.78547 11.0875 6 9.6352 6 7.99946C6 6.40075 6.75033 4.97727 7.91804 4.06199L8.0012 4ZM7.999 5.35446L7.88898 5.48438C7.3219 6.18449 7 7.06486 7 7.99946C7 8.95602 7.33732 9.85508 7.92844 10.5616L8 10.6425L8.07238 10.5616C8.61374 9.91352 8.94207 9.10408 8.99303 8.23722L9 7.99946C9 7.04336 8.66295 6.14432 8.07238 5.43734L7.999 5.35446Z"/>
</svg>

resources/icons/20px/subtract-join.svg
<svg width="20" height="20" viewBox="0 0 20 20" fill="none" xmlns="http://www.w3.org/2000/svg">
<path fill-rule="evenodd" clip-rule="evenodd" d="M14 4C17.3137 4 20 6.68629 20 10C20 13.3137 17.3137 16 14 16C13.2038 16 12.4439 15.8449 11.7488 15.5634C13.1427 14.1229 14 12.1615 14 10C14 7.83846 13.1427 5.87715 11.7497 4.4375C12.4439 4.15507 13.2038 4 14 4ZM6 4C6.7961 4 7.55598 4.15504 8.2511 4.43658C6.85726 5.87715 6 7.83846 6 10C6 12.1615 6.85726 14.1229 8.25033 15.5625C7.55598 15.845 6.7961 16 6 16C2.68629 16 0 13.3137 0 10C0 6.68629 2.68629 4 6 4ZM14 5C13.9068 5 13.8139 5.00254 13.7216 5.0076L13.5 5.025L13.6285 5.22189C14.4587 6.54468 14.9377 8.07401 14.9943 9.6782L15 10C15 11.7213 14.514 13.3673 13.6281 14.7785L13.5 14.974L13.7217 14.9924L14 15C16.7614 15 19 12.7614 19 10C19 7.23858 16.7614 5 14 5Z" fill="#5F6B7C"/>
<path fill-rule="evenodd" clip-rule="evenodd" d="M10 14.4444C11.2275 13.3458 12 11.7492 12 9.97221C12 8.41734 11.4086 7.0006 10.4384 5.93471C10.2998 5.78244 10.1534 5.63733 10 5.5C8.7725 6.59864 8 8.19521 8 9.97221C8 11.7492 8.7725 13.3458 10 14.4444ZM9.91635 7.08577L10.001 6.97221L10.1561 7.19084C10.6991 8.00025 11 8.9614 11 9.97221L10.9937 10.2256C10.9432 11.2343 10.5927 12.1841 10 12.9732L9.84443 12.7537C9.30116 11.9447 9 10.9834 9 9.97221C9 8.91772 9.32735 7.91702 9.91635 7.08577Z" fill="#5F6B7C"/>
</svg>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:

<svg viewBox="0 0 20 20" xmlns="http://www.w3.org/2000/svg">
<path d="M20 10C20 6.68629 17.3137 4 14 4C13.2038 4 12.4439 4.15507 11.7497 4.4375C13.1427 5.87715 14 7.83846 14 10C14 12.1615 13.1427 14.1229 11.7488 15.5634C12.4439 15.8449 13.2038 16 14 16C17.3137 16 20 13.3137 20 10ZM8.2511 4.43658C7.55598 4.15504 6.7961 4 6 4C2.68629 4 0 6.68629 0 10C0 13.3137 2.68629 16 6 16C6.7961 16 7.55598 15.845 8.25033 15.5625C6.85726 14.1229 6 12.1615 6 10C6 7.83846 6.85726 5.87715 8.2511 4.43658ZM13.7216 5.0076C13.8139 5.00254 13.9068 5 14 5C16.7614 5 19 7.23858 19 10C19 12.7614 16.7614 15 14 15L13.7217 14.9924L13.5 14.974L13.6281 14.7785C14.514 13.3673 15 11.7213 15 10L14.9943 9.6782C14.9377 8.07401 14.4587 6.54468 13.6285 5.22189L13.5 5.025L13.7216 5.0076ZM12 9.97221C12 11.7492 11.2275 13.3458 10 14.4444C8.7725 13.3458 8 11.7492 8 9.97221C8 8.19521 8.7725 6.59864 10 5.5C10.1534 5.63733 10.2998 5.78244 10.4384 5.93471C11.4086 7.0006 12 8.41734 12 9.97221ZM10.001 6.97221L9.91635 7.08577C9.32735 7.91702 9 8.91772 9 9.97221C9 10.9834 9.30116 11.9447 9.84443 12.7537L10 12.9732C10.5927 12.1841 10.9432 11.2343 10.9937 10.2256L11 9.97221C11 8.9614 10.6991 8.00025 10.1561 7.19084L10.001 6.97221Z"/>
</svg>

packages/icons/icons.json
"tags": "circles, combine, connect, add, subtract, part, slice, intersection, venn diagram, intersect",
"group": "action",
"codepoint": 62354
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this entry to the end of the array? I'm a bit concerned on us properly incrementing the codepoint field here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggdouglas ggdouglas ggdouglas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annawhittakermuratt @svc-palantir-github @ryannono @ggdouglas