Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(SegmentedControl): option label defaults to value #7052

Merged
merged 5 commits into from
Jan 7, 2025
Merged

fix(SegmentedControl): option label defaults to value #7052

merged 5 commits into from
Jan 7, 2025

Conversation

bvandercar-vt
Copy link
Contributor

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Per OptionProps JSDocs:

/** Label text for this option. If omitted, `value` is used as the label. */
    label?: string;

However, this "value as default" was not occurring for SegmentedControl option props. This fixes that.

Reviewers should focus on:

Fixes the bug so that implementation matches the doc

Screenshot

No visible change

@changelog-app
Copy link

changelog-app bot commented Nov 7, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

fix(SegmentedControl): option label defaults to value

Generate changelog in packages/docs-app/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

fix(SegmentedControl): option label defaults to value

Check the box to generate changelog(s)

  • Generate changelog entry

@ashleighp13 ashleighp13 requested a review from jscheiny November 12, 2024 23:42
@bvandercar-vt
Copy link
Contributor Author

@jscheiny @ggdouglas I rebased this bug fix PR, it's ready.

ggdouglas
ggdouglas approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@ggdouglas ggdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems reasonable to me. Thanks for the catch!

@ggdouglas ggdouglas merged commit 1e9da5a into palantir:develop Jan 7, 2025
12 of 15 checks passed
@bvandercar-vt bvandercar-vt deleted the bvandercar/segmentedcontrol-default-label branch January 8, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggdouglas ggdouglas ggdouglas approved these changes

@jscheiny jscheiny Awaiting requested review from jscheiny

Assignees

@jscheiny jscheiny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bvandercar-vt @ggdouglas @jscheiny