Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Overlay,Overlay2): remove overlay outer tabIndex #6991

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

fix(Overlay,Overlay2): remove overlay outer tabIndex #6991

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
79ffe90
remove overlay outer tabIndex
bvandercar-vt Sep 19, 2024
25e47ed
ws
bvandercar-vt Sep 19, 2024
5a6e58b
ws
bvandercar-vt Sep 19, 2024
9f8aa57
ws
bvandercar-vt Sep 19, 2024
9ae2982
ws
bvandercar-vt Sep 19, 2024
c50c5d1
remove unused deps
bvandercar-vt Sep 20, 2024
51852e5
Merge branch 'develop' into bvandercar/fix-overlay-autoFocus
bvandercar-vt Sep 23, 2024
0562748
Merge branch 'develop' into bvandercar/fix-overlay-autoFocus
bvandercar-vt Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ws
  • Loading branch information
@bvandercar-vt
bvandercar-vt committed Sep 19, 2024
commit 25e47edb48582e5f3db7226d5984fd071267e6ce
2 changes: 1 addition & 1 deletion packages/core/src/components/overlay2/overlay2.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ export const Overlay2 = React.forwardRef<OverlayInstance, Overlay2Props>((props,
return;
}

// Overlay2 is guaranteed to be mounted here
// Overlay2 is guaranteed to be mounted here
const isFocusOutsideModal = !container.contains(activeElement);
if (isFocusOutsideModal) {
getRef(startFocusTrapElement)?.focus({ preventScroll: true });
Expand Down