Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotkeys v2 with hooks #4532

Merged
merged 10 commits into from
Feb 18, 2021
Merged

Hotkeys v2 with hooks #4532

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f98f481
WIP useHotkeys
adidahiya Feb 16, 2021
89c5a9b
useHotkeys example, HotkeysTarget2
adidahiya Feb 16, 2021
07b4dca
[cherry pick me] remove 'new' tag from some docs pages
adidahiya Feb 16, 2021
02b4539
migration docs
adidahiya Feb 16, 2021
c702efb
Add HotkeysProvider, HotkeysDialog2, fix examples
adidahiya Feb 17, 2021
82a3ac1
fix lint in table package
adidahiya Feb 17, 2021
07c1fba
finish hotkey docs
adidahiya Feb 18, 2021
74b10c8
fix lint, drop test coverage
adidahiya Feb 18, 2021
9c3b4aa
guard against createContext undefined
adidahiya Feb 18, 2021
b35b869
fix compilation
adidahiya Feb 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
guard against createContext undefined
  • Loading branch information
@adidahiya
adidahiya committed Feb 18, 2021
commit 9c3b4aa917c7c3753910eca78fd13ad8e810a141
7 changes: 3 additions & 4 deletions packages/core/src/context/hotkeys/hotkeysProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,10 @@ type HotkeysAction =
| { type: "CLOSE_DIALOG" | "OPEN_DIALOG" };

const initialHotkeysState: HotkeysContextState = { hotkeys: [], isDialogOpen: false };
const noOpDispatch: Dispatch<HotkeysAction> = () => null;

export const HotkeysContext = createContext<[HotkeysContextState, Dispatch<HotkeysAction>]>([
initialHotkeysState,
() => null,
]);
// we can remove this guard once Blueprint depends on React 16
export const HotkeysContext = createContext?.([initialHotkeysState, noOpDispatch]);

const hotkeysReducer = (state: HotkeysContextState, action: HotkeysAction) => {
switch (action.type) {
Expand Down