fix: ConsumerVersionSelector interface (BREAKING CHANGE) #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I haven’t had the chance to get to this issue yet, so it’s much appreciated. I hope to have a look over the weekend. Unless I’m mistaken, this is a breaking change, yes? |
Based on document of pact_broker:pact-foundation/pact_broker#307, ConsumerVersionSelector interface attributes are not compatible This fix is to update it BREAKING CHANGE: fix pact-foundation#285
tonynguyenit18
force-pushed
the
fix/consumer-version-selector-interface
branch
from
9cd3df5 to
b1e5afe
Compare
tonynguyenit18
changed the title
|
Thanks @TimothyJones |
5 tasks
|
Hi @TimothyJones |
|
See pact-foundation/pact-js#649 (comment). We'll aim to do this next week. For now Tony, the workaround in TS would be to specify the correct underlying JSON data structure and do a cast to force it in. |
|
@mefellows : I reckon it would be a good time to do #263 when we merge this. I can take a look this weekend if you haven't had the chance yet. |
|
Yep that'd be great Tim. Good idea.
…On Fri, 21 May 2021, 5:53 pm Timothy Jones, ***@***.***> wrote:
Merged #286 <#286>
into master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#286 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAANFDEWI35Y5QMTM3EGN3LTOYGQHANCNFSM44KLGO5A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incompatible
ConsumerVersionSelectorinterface attributes based on new pact_broker docsFix: pact-foundation/pact-js#649 and #285