Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue#108: Remove last remaining occurrences of HOST_TO_NET and NET_TO_HOST from spec. #117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thomascalvert-xlnx
Copy link
Member

@thomascalvert-xlnx thomascalvert-xlnx commented Mar 20, 2023

Also move the obsolete packet path figures in to the historical subdirectory - these will eventually need to be redone as per the TBD in the text (§ 6 and appendix D).

Was able to regenerate the HTML & PDF and the updated table 1 looks OK.

With these changes there are no remaining occurrences of HOST_TO_NET or NET_TO_HOST in the repository.

Edit: link issue #108

Copy link
Collaborator

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, with one minor comment.

PNA.mdk Outdated
| Description | next by | packet(s) |
+:--------------+:--------------+:-----------------------+
| packet from | main | Zero or more mirrored |
| network port | | packets |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "Resulting packet(s)" column, would it be more accurate to expand it to something like the following text?

Zero or more mirrored packets, plus at most one copy of the original packet (which may be marked for recirculation).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the mirrored packets also allowed to be recirculated? I would think yes, as it may be the only way to support broadcast traffic to a number of VMs larger than the target's maximum mirror slots.

Is the original packet always emitted albeit possibly marked for drop? (The comment in the P4 file says it is dropped after the end of the control block.)

If both the above are true, I would suggest this text:

Original packet which may be recirculated or marked for drop, and zero or more mirrored packets some of which may be recirculated.

I'm also adding a forward reference to the packet mirroring section (§6.8) in the corresponding paragraph just after this table.

@thomascalvert-xlnx thomascalvert-xlnx force-pushed the 108_remove-obsolete-directions branch from ca8609a to e35bcde Compare September 18, 2023 19:13
@thomascalvert-xlnx
Copy link
Member Author

Text changed as suggested, and forward reference added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants