Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser graph generation support for graphs backend #969

Merged
merged 5 commits into from
Oct 30, 2017
Merged

parser graph generation support for graphs backend #969

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
098e404
parser graph generation support for graphs backend
c3m3gyanesh Oct 13, 2017
f2a7618
cpplint fix- tab2whitespace
c3m3gyanesh Oct 13, 2017
3f84ad8
header guard style fix
c3m3gyanesh Oct 13, 2017
c9975c6
create graph base class, using rectangles in graphs
c3m3gyanesh Oct 17, 2017
3b75ee2
main func and Graph methods are separed to different files:p4c-graphs…
c3m3gyanesh Oct 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
header guard style fix
  • Loading branch information
@c3m3gyanesh
c3m3gyanesh committed Oct 13, 2017
commit 3f84ad862b4bb90223d67e47f548a64daf4f2d9f
6 changes: 3 additions & 3 deletions backends/graphs/graphs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

#ifndef _BACKENDS_GRAPHS_CONTROLS_H_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a little confusing to call this file graphs.h, given that none of the classes it prototypes are implemented in graphs.cpp.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the common header file for both control.cpp and parser.cpp.
If you have any other suggestion for names, i would appreciate that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe graph_generators.h if you want to have a single header file for both control and parser

Copy link
Contributor

@ChrisDodd ChrisDodd Oct 13, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you refactor ParserGraphs and ControlGraphs into a single Graphs (abstract) base class with ParserGraphs and ControlGraphs as (simpler) subclasses, then I think this organization does make a fair amount of sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to refactor the classes and created a Graphs base class.

#define _BACKENDS_GRAPHS_CONTROLS_H_
#ifndef _BACKENDS_GRAPHS_GRAPHS_H_
#define _BACKENDS_GRAPHS_GRAPHS_H_

#include "config.h"

Expand Down Expand Up @@ -223,4 +223,4 @@ class ParserGraphs : public Inspector {

} // namespace graphs

#endif // _BACKENDS_GRAPHS_CONTROLS_H_
#endif // _BACKENDS_GRAPHS_GRAPHS_H_