Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combo of duplication action name check and LocalizeAllActions fix #4975

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open

Combo of duplication action name check and LocalizeAllActions fix #4975

Changes from 1 commit
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
e429c8a
Add pass to give error if duplicate hierarchical names are present
jafingerhut Oct 7, 2024
39538bf
Add new source files to CMakeLists.txt
jafingerhut Oct 7, 2024
98940fb
Skip new checks when compiling certain source files including: + Sour…
jafingerhut Oct 8, 2024
a2792ce
Skip new checks for P4-14 source files in run-bmv2-test.py
jafingerhut Oct 8, 2024
a553fe1
Fix lint error
jafingerhut Oct 8, 2024
26f0501
Fix lint problems.
jafingerhut Oct 8, 2024
da456fe
Do not give errors for variable declarations with identical names
jafingerhut Oct 8, 2024
b683571
Limit search for duplicate names to actions, tables, or "other objects"
jafingerhut Oct 8, 2024
ad40fe9
Update test programs that had errors in their name annotations
jafingerhut Oct 9, 2024
91166c8
Update expected output files for modified test programs
jafingerhut Oct 9, 2024
9acb7e0
Move new test program with error into p4_16_errors directory
jafingerhut Oct 9, 2024
b133b28
Add expected output files for new test programs
jafingerhut Oct 9, 2024
76bf24f
More fine-tuning to enable tests to pass
jafingerhut Oct 9, 2024
f7ec2fe
Fix lint error
jafingerhut Oct 9, 2024
1cc8224
Fix lint error
jafingerhut Oct 9, 2024
4b03eb5
Merge branch 'master' into add-duplicate-hierarchical-name-check-pass
jafingerhut Oct 9, 2024
93daba5
Address some review comments
jafingerhut Oct 9, 2024
66a0a0a
Rewording documentation of new pass for clarity.
jafingerhut Oct 9, 2024
083db34
Merge remote-tracking branch 'upstream/main' into add-duplicate-hiera…
jafingerhut Oct 12, 2024
99beb30
Enable the new pass only if P4Runtime control plane API gen is enabled
jafingerhut Oct 20, 2024
2b7c58a
Merge branch 'add-duplicate-hierarchical-name-check-pass' of github.c…
jafingerhut Oct 20, 2024
54007df
Merge remote-tracking branch 'upstream/main' into add-duplicate-hiera…
jafingerhut Oct 20, 2024
d89f214
Undo changes to Python test scripts
jafingerhut Oct 20, 2024
7424db3
Undo changes to gtestp4c source
jafingerhut Oct 20, 2024
55ad18f
Merge remote-tracking branch 'upstream/main' into add-duplicate-hiera…
jafingerhut Oct 20, 2024
799448a
Use abseil StrCat and StrAppend instead of loop
jafingerhut Oct 21, 2024
377f41a
Fix formatting with clang-format
jafingerhut Oct 21, 2024
682564b
Fix #4969 by modifying pass LocalizeActions
jafingerhut Oct 21, 2024
bb88b7d
Fix clang-format error
jafingerhut Oct 21, 2024
d265e1c
Also catch duplicates involving top-level actions without @name annot…
jafingerhut Oct 21, 2024
606300e
Merge remote-tracking branch 'upstream/main' into add-duplicate-hiera…
jafingerhut Oct 21, 2024
6bcb614
Add new test program to exercise latest code changes
jafingerhut Oct 21, 2024
55da2c3
Change pass name to reflect only checking action control plane names
jafingerhut Oct 21, 2024
d67df83
Fix lint warning, and add one more successful test program
jafingerhut Oct 22, 2024
42c1dee
Merge remote-tracking branch 'origin/fix-localizeallactions-bug' into…
jafingerhut Oct 22, 2024
95dc4e2
A few more fixes and test cases for duplicate action name checks
jafingerhut Oct 22, 2024
efd0d52
Fix code formatting to pass lint check
jafingerhut Oct 22, 2024
4540f2a
Fix lint warning for Python code
jafingerhut Oct 22, 2024
39a9251
Update old file name in CMakeLists.txt
jafingerhut Oct 23, 2024
62fe180
Merge remote-tracking branch 'upstream/main' into combo-of-duplicatio…
jafingerhut Oct 23, 2024
b614ff9
Add another case of conflicting action names between control and sub-…
jafingerhut Oct 25, 2024
968af1f
Merge remote-tracking branch 'upstream/main' into combo-of-duplicatio…
jafingerhut Oct 25, 2024
a2e913b
Add another correct case of not-conflicting @name annotations involvi…
jafingerhut Oct 25, 2024
72827dd
Fix comment, and remove unnecessary comment in P4 test program
jafingerhut Oct 30, 2024
b9a0ee9
Merge remote-tracking branch 'upstream/main' into combo-of-duplicatio…
jafingerhut Oct 30, 2024
019f3c6
Merge remote-tracking branch 'upstream/main' into combo-of-duplicatio…
jafingerhut Oct 31, 2024
bb50cc6
Put method controlPlaneAPIGenEnabled in class CompilerOptions
jafingerhut Nov 5, 2024
a840163
Fixes for incorrect previous commit.
jafingerhut Nov 5, 2024
19956fc
Fix cpplint warning from clang-format
jafingerhut Nov 5, 2024
e563b90
Merge remote-tracking branch 'upstream/main' into combo-of-duplicatio…
jafingerhut Nov 9, 2024
62ee2c1
Updates due to recent changes in annotation APIs
jafingerhut Nov 9, 2024
c3feb19
More modifications required to make the code work with ...
jafingerhut Nov 9, 2024
31f0b10
Simplify string manipulation code using latest abseil changes
jafingerhut Nov 10, 2024
bd31e6b
Fix clang-format warning
jafingerhut Nov 10, 2024
a853313
Merge branch 'master' into combo-of-duplication-action-name-check-and…
jafingerhut Dec 2, 2024
c111ab1
Updates required to work with recent changes to annotation implementa…
jafingerhut Dec 2, 2024
b542540
Address review comments
jafingerhut Dec 2, 2024
beb87b0
Removed an old line of commented-out code.
jafingerhut Dec 2, 2024
87feba6
Reword some comments for clarity.
jafingerhut Dec 2, 2024
e586849
Fix lint warning
jafingerhut Dec 2, 2024
381ec48
Address review comment
jafingerhut Dec 3, 2024
2f861cf
Merge remote-tracking branch 'upstream/main' into combo-of-duplicatio…
jafingerhut Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint warning 
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
  • Loading branch information
@jafingerhut
jafingerhut committed Dec 2, 2024
commit e586849fa544c709490b352281655068d8baac1f
1 change: 1 addition & 0 deletions frontends/p4/duplicateActionControlPlaneNameCheck.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ limitations under the License.
#define FRONTENDS_P4_DUPLICATEACTIONCONTROLPLANENAMECHECK_H_

#include <vector>

#include "ir/ir.h"
#include "ir/visitor.h"

Expand Down
Loading