Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete unused RemoveComplexExpressions pass. #4771

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Delete unused RemoveComplexExpressions pass. #4771

merged 1 commit into from
Jul 1, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jul 1, 2024 •
edited
Loading

It looks like this pass was never used (and was added mistakenly). It does not even compile. There is already a midend pass doing a similar thing.

@fruffy
Delete unused complex expressions.
2f5a4eb 
Signed-off-by: fruffy <fruffy@nyu.edu>
@fruffy fruffy added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label Jul 1, 2024
@fruffy fruffy changed the title Delete unused complex expressions. Delete unused RemoveComplexExpressions pass. Jul 1, 2024
@fruffy fruffy marked this pull request as ready for review July 1, 2024 18:37
@fruffy fruffy enabled auto-merge July 1, 2024 18:37
@fruffy fruffy added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit a0e9476 Jul 1, 2024
17 checks passed
@fruffy fruffy deleted the fruffy/complex_expressions branch July 1, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcripps kfcripps kfcripps approved these changes

Assignees
No one assigned
Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruffy @kfcripps