Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add P4Tools to the P4C docker image. #4094

Closed
wants to merge 1 commit into from
Closed

Add P4Tools to the P4C docker image. #4094

wants to merge 1 commit into from

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Aug 3, 2023

There is no P4C container yet which contains P4tools. Enable P4Tools for the container build so that we can easily share P4tools docker images.

@fruffy fruffy requested review from jafingerhut and rst0git August 3, 2023 13:32
@rst0git
Copy link
Member

rst0git commented Aug 3, 2023

@fruffy ENABLE_TEST_TOOLS appears to be set in the Dockerfile:

p4c/Dockerfile

Line 28 in b1b0fde

ARG ENABLE_TEST_TOOLS=ON 

$ sudo podman run p4lang/p4c p4testgen --version
p4testgen
Version 1.2.4

@fruffy
Copy link
Collaborator Author

fruffy commented Aug 3, 2023 •
edited
Loading

Oh, how convenient. For some reason I remembered it to be turned off by default.
#4049 was the change, I even approved it 😅

@fruffy fruffy closed this Aug 3, 2023
@fruffy fruffy deleted the fruffy/add_tools_to_docker branch August 3, 2023 13:55
@fruffy
Copy link
Collaborator Author

fruffy commented Aug 4, 2023

@fruffy ENABLE_TEST_TOOLS appears to be set in the Dockerfile:

p4c/Dockerfile

Line 28 in b1b0fde

ARG ENABLE_TEST_TOOLS=ON 

$ sudo podman run p4lang/p4c p4testgen --version
p4testgen
Version 1.2.4

Quick question, the debian packages do not include p4testgen, right?

@rst0git
Copy link
Member

rst0git commented Aug 4, 2023

Quick question, the debian packages do not include p4testgen, right?

ENABLE_TEST_TOOLS is not currently set.

Would you like me to enable it?

@fruffy
Copy link
Collaborator Author

fruffy commented Aug 4, 2023

Yes, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut Awaiting requested review from jafingerhut

@rst0git rst0git Awaiting requested review from rst0git

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruffy @rst0git