Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P4Tools: Implement default action override for BMv2 STF. #3685

Merged
merged 4 commits into from
Nov 22, 2022
Merged

P4Tools: Implement default action override for BMv2 STF. #3685

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6754a1a
Implement default action override for BMv2 STF.
fruffy Nov 10, 2022
09dd23d
Fix up BMv2 set default command.
fruffy Nov 11, 2022
1b86265
Mitigate issues with multicast.
fruffy Nov 11, 2022
342412e
Refactor test frameworks and use a utility library.
fruffy Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix up BMv2 set default command.
  • Loading branch information
@fruffy
fruffy committed Nov 22, 2022
commit 09dd23d8651801096b8fa47878c15a8c2fe7e0b0
2 changes: 1 addition & 1 deletion backends/bmv2/bmv2stf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ def parse_table_set_default(self, cmd):
actionArgs.set(k, v)
command = "table_set_default " + tableName + " " + actionName
if actionArgs.size():
command += " => " + str(actionArgs)
command += " " + str(actionArgs)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a bug in the STF test framework. Default action overrides were not using the correct syntax.

return command
def parse_table_add(self, cmd):
tableName, cmd = nextWord(cmd)
Expand Down
2 changes: 1 addition & 1 deletion backends/p4tools/testgen/targets/bmv2/test/BMV2Xfail.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ p4tools_add_xfail_reason(

p4tools_add_xfail_reason(
"testgen-p4c-bmv2"
"Unknown extern method count from type jnf_counter"
"Unknown or unimplemented extern method: count"
# user defined extern
issue1193-bmv2.p4
)
Expand Down