Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
p4c-ubpf: new uBPF back-end for p4c #2134
p4c-ubpf: new uBPF back-end for p4c #2134
Changes from 1 commit
ecd39c0
ec22005
a687110
75fdcf6
2fcdcf8
acfaa6e
99d6854
78335fa
93643c2
118b2b2
884c40a
d57742f
dcf0903
3d64116
9231f53
dbb237e
1090527
c0bc2c5
0df4fa5
5a86d96
b96fcca
b880030
3089cbb
edcbb1d
cfaa628
5cc9931
c63a939
322f5c1
1adffa0
b3eb458
5893f22
0ca94d3
085294b
8ab0e2a
302d279
381d4ee
e4330a8
1fd859e
08b7de0
b8b3f06
e22ad6f
38acee5
c648326
c5c324e
7f0b72e
2b6020c
997d5db
db6c4db
2e12ee3
6bc8674
7ec6f33
2be7ec7
b1479ad
668e808
6ae22e4
cc59b0d
fb07d84
daad335
f5bcc01
89eb992
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make it clear: this is a constraint that you have chosen. In P4 you could even declare a generic
hash<T>(in T data)
which works for any P4 datatype.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that's the limitation of our implementation. In particular, it is the limitation of the
ubpf_hash()
helper that we use to compute hash value. Also, to be improved in the future.