Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IAnnotated where possible #2035

Merged
merged 2 commits into from
Sep 19, 2019
Merged

Implement IAnnotated where possible #2035

merged 2 commits into from
Sep 19, 2019

Conversation

liujed
Copy link
Member

@liujed liujed commented Sep 18, 2019

A bunch of classes in v1.def weren't implementing IAnnotated when they really should have.

Also fixed a missing #include.

mihaibudiu
mihaibudiu approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@mihaibudiu mihaibudiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't checked if there are missing ones, but these look good.

@liujed liujed merged commit a87d0b8 into master Sep 19, 2019
@liujed liujed deleted the jed/tweaks branch September 19, 2019 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaibudiu mihaibudiu mihaibudiu approved these changes

@ChrisDodd ChrisDodd Awaiting requested review from ChrisDodd

@hanw hanw Awaiting requested review from hanw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liujed @mihaibudiu