Skip to content

Commit

Permalink
Change Dockerfile to build p4tools by default. (#4049)
Browse files Browse the repository at this point in the history
* Change Dockerfile to build p4tools by default. Will affect images published to Dockerhub.

* Suppress CI from building p4tools for Ubuntu 18.04.
  • Loading branch information
chrispsommers authored Jun 27, 2023
1 parent e741876 commit a6553f1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/ci-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,8 @@ jobs:

- name: Build (Ubuntu 18.04, GCC)
run: |
docker build -t p4c --build-arg BASE_IMAGE=ubuntu:18.04 --build-arg IMAGE_TYPE=test .
docker build -t p4c --build-arg BASE_IMAGE=ubuntu:18.04 --build-arg IMAGE_TYPE=test \
--build-arg ENABLE_TEST_TOOLS=OFF .
./tools/export_ccache.sh
# run with sudo (...) --privileged
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ ARG DEBIAN_FRONTEND=noninteractive
# Whether to install dependencies required to run PTF-ebpf tests
ARG INSTALL_PTF_EBPF_DEPENDENCIES=OFF
# Whether to build the P4Tools back end and platform.
ARG ENABLE_TEST_TOOLS=OFF
ARG ENABLE_TEST_TOOLS=ON
# Whether to treat warnings as errors.
ARG ENABLE_WERROR=ON
# Compile with Clang compiler
Expand Down

0 comments on commit a6553f1

Please sign in to comment.