Fix some comments

p00ya · May 19, 2023 · 89e8f62 · 89e8f62
1 parent 137861e
commit 89e8f62
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 15 deletions.
diff --git a/keyboards/ergodox_ez/keymaps/p00ya_dvorak/config.h b/keyboards/ergodox_ez/keymaps/p00ya_dvorak/config.h
@@ -5,16 +5,15 @@
 //
 // Ergodox EZ scan rate (measured with DEBUG_MATRIX_SCAN_RATE) is:
 // asym_eager_defer_pk: 613Hz
-// eager_pr: 701Hz
-// i.e. around 1.5ms
+// sym_eager_pr: 701Hz
+// i.e. around 1.5ms between scans
 //
-// My maximum typing speed is ~180WPM; 60 / (180 * 6) = ~5ms between strokes.
+// My maximum typing speed is ~180WPM; 60 / (180 * 6) = ~55ms between strokes.
 
-
-// Ergodox EZ uses eager_pr debounce by default, so this only delays key down
-// events on physical *columns* (matrix rows).  Kailh and Cherry switches
-// specify a 5ms debounce but there is some question of noise in the Ergodox
-// itself.  The default is 30ms.
+// Kailh and Cherry switches specify a 5ms debounce but there is some question
+// of noise in the Ergodox itself.  The default is 30ms with sym_eager_pr.
+// With eager debouncing we can use high debounce intervals without delaying
+// the initial downstroke.
 
 #undef DEBOUNCE
 #define DEBOUNCE 32

diff --git a/keyboards/ergodox_ez/keymaps/p00ya_dvorak/keymap.c b/keyboards/ergodox_ez/keymaps/p00ya_dvorak/keymap.c
@@ -68,8 +68,7 @@ enum {
 // clang-format off
 const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
   // Base layer should mostly act like a 60% US (QWERTY) layout, with some of
-  // the right pinky keys missing, caps-lock remapped as ctrl, and grave
-  // replaced with esc.
+  // the right pinky keys missing, caps-lock remapped as ctrl/esc.
   [0] = LAYOUT_ergodox_pretty(
     KC_GRV,  KC_1,    KC_2,    KC_3,    KC_4,    KC_5,    KC_6,                              _______, KC_6,    KC_7,    KC_8,    KC_9,    KC_0,    KC_BSPC,
     KC_TAB,  KC_Q,    KC_W,    KC_E,    KC_R,    KC_T,    _______,                           _______, KC_Y,    KC_U,    KC_I,    KC_O,    KC_P,    KC_LBRC,

diff --git a/keyboards/keebio/iris/keymaps/p00ya_dvorak/keymap.c b/keyboards/keebio/iris/keymaps/p00ya_dvorak/keymap.c
@@ -40,9 +40,6 @@
 // Mod-tap for esc / ctrl.
 #define MT_CESC MT(MOD_LCTL, KC_ESC)
 
-// Layer-tap for Enter / alt-compatability.
-#define LT_ENT LT(L_ALT, KC_ENT)
-
 // Shift and fn (double-tap).
 #define LT_SHFN LT(L_FN, KC_LSFT)
 
@@ -74,7 +71,7 @@ enum {
 // clang-format off
 const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
   // Base layer should mostly act like a 60% US (QWERTY) layout, with some of
-  // the right pinky keys missing, caps-lock remapped as ctrl, and grave
+  // the right pinky keys missing, caps-lock remapped as ctrl/esc.
   // replaced with esc.
   [0] = LAYOUT(
     KC_GRV,  KC_1,    KC_2,    KC_3,    KC_4,    KC_5,                                       KC_6,    KC_7,    KC_8,    KC_9,    KC_0,    KC_BSPC,
@@ -192,7 +189,7 @@ enum {
 };
 
 // Sets "led" to the given colour if it's in the min/max range, and "on"
-// is true.  "on" is only evaluated
+// is true.  "on" is only evaluated if "led" is in the range.
 // led_min and led_max must be defined in the context this macro is called.
 #define MAYBE_SET_COLOR(led, on, color) \
     if (led_min <= led && led < led_max && on) { \